-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: sqlite add set and minor cleanup #4018
Conversation
316c7a4
to
d945167
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@@ -90,7 +90,7 @@ declare namespace CacheHandler { | |||
headers: Record<string, string | string[]> | |||
vary?: Record<string, string | string[]> | |||
etag?: string | |||
body: null | Readable | Iterable<Buffer> | AsyncIterable<Buffer> | Buffer | Iterable<string> | AsyncIterable<string> | string | |||
body?: Readable | Iterable<Buffer> | AsyncIterable<Buffer> | Buffer | Iterable<string> | AsyncIterable<string> | string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This wouldn't be breaking if we drop null
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
CI is not happy |
## [1.11.3](v1.11.2...v1.11.3) (2025-02-04) ### Bug Fixes * **deps:** bump the production-dependencies group with 3 updates ([#203](#203)) ([8e85a3c](8e85a3c)), closes [#665](https://github.com/actions/create-github-app-token/issues/665) [#665](https://github.com/actions/create-github-app-token/issues/665) [#663](https://github.com/actions/create-github-app-token/issues/663) [#662](https://github.com/actions/create-github-app-token/issues/662) [#661](https://github.com/actions/create-github-app-token/issues/661) [#659](https://github.com/actions/create-github-app-token/issues/659) [#660](https://github.com/actions/create-github-app-token/issues/660) [#658](https://github.com/actions/create-github-app-token/issues/658) [#656](https://github.com/actions/create-github-app-token/issues/656) [#657](https://github.com/actions/create-github-app-token/issues/657) [#655](https://github.com/actions/create-github-app-token/issues/655) [#731](https://github.com/actions/create-github-app-token/issues/731) [nodejs/undici#4016](nodejs/undici#4016) [nodejs/undici#4017](nodejs/undici#4017) [nodejs/undici#4018](nodejs/undici#4018) [nodejs/undici#4008](nodejs/undici#4008) [nodejs/undici#3991](nodejs/undici#3991) [nodejs/undici#4001](nodejs/undici#4001) [nodejs/undici#3980](nodejs/undici#3980) [nodejs/undici#4003](nodejs/undici#4003) [nodejs/undici#3965](nodejs/undici#3965) [nodejs/undici#4002](nodejs/undici#4002) [nodejs/undici#4006](nodejs/undici#4006) [nodejs/undici#3956](nodejs/undici#3956) [nodejs/undici#3964](nodejs/undici#3964) [nodejs/undici#3447](nodejs/undici#3447) [#3966](https://github.com/actions/create-github-app-token/issues/3966) [nodejs/undici#3967](nodejs/undici#3967) [nodejs/undici#3971](nodejs/undici#3971) [nodejs/undici#3954](nodejs/undici#3954) [nodejs/undici#3972](nodejs/undici#3972) [nodejs/undici#3974](nodejs/undici#3974) [nodejs/undici#3976](nodejs/undici#3976) [#3975](https://github.com/actions/create-github-app-token/issues/3975) [nodejs/undici#3977](nodejs/undici#3977) [nodejs/undici#3978](nodejs/undici#3978) [nodejs/undici#3981](nodejs/undici#3981) [nodejs/undici#3983](nodejs/undici#3983) [nodejs/undici#3986](nodejs/undici#3986) [#4021](https://github.com/actions/create-github-app-token/issues/4021) [#4018](https://github.com/actions/create-github-app-token/issues/4018) [#4017](https://github.com/actions/create-github-app-token/issues/4017) [#4016](https://github.com/actions/create-github-app-token/issues/4016) [#4008](https://github.com/actions/create-github-app-token/issues/4008) [#4007](https://github.com/actions/create-github-app-token/issues/4007) [#4006](https://github.com/actions/create-github-app-token/issues/4006) [#3965](https://github.com/actions/create-github-app-token/issues/3965)
…→ v1.11.3 ) (#461) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/create-github-app-token](https://redirect.github.com/actions/create-github-app-token) | action | patch | `v1.11.2` -> `v1.11.3` | --- ### Release Notes <details> <summary>actions/create-github-app-token (actions/create-github-app-token)</summary> ### [`v1.11.3`](https://redirect.github.com/actions/create-github-app-token/releases/tag/v1.11.3) [Compare Source](https://redirect.github.com/actions/create-github-app-token/compare/v1.11.2...v1.11.3) ##### Bug Fixes - **deps:** bump the production-dependencies group with 3 updates ([#​203](https://redirect.github.com/actions/create-github-app-token/issues/203)) ([8e85a3c](https://redirect.github.com/actions/create-github-app-token/commit/8e85a3cf1418b864b528ed9c756cd9c84932d442)), closes [#​665](https://redirect.github.com/actions/create-github-app-token/issues/665) [#​665](https://redirect.github.com/actions/create-github-app-token/issues/665) [#​663](https://redirect.github.com/actions/create-github-app-token/issues/663) [#​662](https://redirect.github.com/actions/create-github-app-token/issues/662) [#​661](https://redirect.github.com/actions/create-github-app-token/issues/661) [#​659](https://redirect.github.com/actions/create-github-app-token/issues/659) [#​660](https://redirect.github.com/actions/create-github-app-token/issues/660) [#​658](https://redirect.github.com/actions/create-github-app-token/issues/658) [#​656](https://redirect.github.com/actions/create-github-app-token/issues/656) [#​657](https://redirect.github.com/actions/create-github-app-token/issues/657) [#​655](https://redirect.github.com/actions/create-github-app-token/issues/655) [#​731](https://redirect.github.com/actions/create-github-app-token/issues/731) [nodejs/undici#4016](https://redirect.github.com/nodejs/undici/issues/4016) [nodejs/undici#4017](https://redirect.github.com/nodejs/undici/issues/4017) [nodejs/undici#4018](https://redirect.github.com/nodejs/undici/issues/4018) [nodejs/undici#4008](https://redirect.github.com/nodejs/undici/issues/4008) [nodejs/undici#3991](https://redirect.github.com/nodejs/undici/issues/3991) [nodejs/undici#4001](https://redirect.github.com/nodejs/undici/issues/4001) [nodejs/undici#3980](https://redirect.github.com/nodejs/undici/issues/3980) [nodejs/undici#4003](https://redirect.github.com/nodejs/undici/issues/4003) [nodejs/undici#3965](https://redirect.github.com/nodejs/undici/issues/3965) [nodejs/undici#4002](https://redirect.github.com/nodejs/undici/issues/4002) [nodejs/undici#4006](https://redirect.github.com/nodejs/undici/issues/4006) [nodejs/undici#3956](https://redirect.github.com/nodejs/undici/issues/3956) [nodejs/undici#3964](https://redirect.github.com/nodejs/undici/issues/3964) [nodejs/undici#3447](https://redirect.github.com/nodejs/undici/issues/3447) [#​3966](https://redirect.github.com/actions/create-github-app-token/issues/3966) [nodejs/undici#3967](https://redirect.github.com/nodejs/undici/issues/3967) [nodejs/undici#3971](https://redirect.github.com/nodejs/undici/issues/3971) [nodejs/undici#3954](https://redirect.github.com/nodejs/undici/issues/3954) [nodejs/undici#3972](https://redirect.github.com/nodejs/undici/issues/3972) [nodejs/undici#3974](https://redirect.github.com/nodejs/undici/issues/3974) [nodejs/undici#3976](https://redirect.github.com/nodejs/undici/issues/3976) [#​3975](https://redirect.github.com/actions/create-github-app-token/issues/3975) [nodejs/undici#3977](https://redirect.github.com/nodejs/undici/issues/3977) [nodejs/undici#3978](https://redirect.github.com/nodejs/undici/issues/3978) [nodejs/undici#3981](https://redirect.github.com/nodejs/undici/issues/3981) [nodejs/undici#3983](https://redirect.github.com/nodejs/undici/issues/3983) [nodejs/undici#3986](https://redirect.github.com/nodejs/undici/issues/3986) [#​4021](https://redirect.github.com/actions/create-github-app-token/issues/4021) [#​4018](https://redirect.github.com/actions/create-github-app-token/issues/4018) [#​4017](https://redirect.github.com/actions/create-github-app-token/issues/4017) [#​4016](https://redirect.github.com/actions/create-github-app-token/issues/4016) [#​4008](https://redirect.github.com/actions/create-github-app-token/issues/4008) [#​4007](https://redirect.github.com/actions/create-github-app-token/issues/4007) [#​4006](https://redirect.github.com/actions/create-github-app-token/issues/4006) [#​3965](https://redirect.github.com/actions/create-github-app-token/issues/3965) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://redirect.github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xNTguMSIsInVwZGF0ZWRJblZlciI6IjM5LjE1OC4xIiwidGFyZ2V0QnJhbmNoIjoiZGV2IiwibGFiZWxzIjpbInJlbm92YXRlL2dpdGh1Yi1hY3Rpb24iLCJyZW5vdmF0ZS9naXRodWItcmVsZWFzZSIsInR5cGUvcGF0Y2giXX0=--> Co-authored-by: bloopy-boi[bot] <98279278+bloopy-boi[bot]@users.noreply.github.com>
set is a more performant variant of createWriteStream for small responses...